Renaming tasklist.NewIdentifier() result #6113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a) taskList is misleading as we're retrieving taskList itself later in some functions. b) consistency: some functinos of the file already use tasklistID for the same purpose.
dkrotx
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
approved these changes
Jun 5, 2024
Pull Request Test Coverage Report for Build 018fea2a-9ba1-4126-9c6e-43ee4e57e834Details
💛 - Coveralls |
timl3136
pushed a commit
to timl3136/cadence
that referenced
this pull request
Jun 6, 2024
a) taskList is misleading as we're retrieving taskList itself later in some functions. b) consistency: some functinos of the file already use tasklistID for the same purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) taskList is misleading as we're retrieving taskList itself later in
some functions.
b) consistency: some functinos of the file already use tasklistID for the same
purpose.
renamed taskList -> taskListID because of the above reasons
refactoring during deep dive session
How did you test it?
Potential risks
Release notes
Documentation Changes