Add tests for service/matching/handler/handler.go #6116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 34 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018fea7a-18b7-47bd-a290-626b1503cb11Details
💛 - Coveralls |
**What changed?** tests for service/matching/handler/handler.go **Why?** improve unit test coverage **How did you test it?** unit tests **Potential risks** **Release notes** **Documentation Changes**
fimanishi
force-pushed
the
tests-for-matching-handler
branch
from
8d5991d
to
57e712e
Compare
fimanishi
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018feab2-8717-4ed8-a03c-5959e4a21454Details
💛 - Coveralls |
shijiesheng
reviewed
Jun 6, 2024
| wg.Wait() | ||
| } | ||
|
|
||
| func (s *handlerSuite) TestStop() { |
There was a problem hiding this comment.
add go routine leak detection. goleak.VerifyNone
shijiesheng
approved these changes
Jun 6, 2024
fimanishi
force-pushed
the
tests-for-matching-handler
branch
from
dee5e29
to
f01e807
Compare
Pull Request Test Coverage Report for Build 018fee8f-064e-4387-b1d1-93c64d6eb36fDetails
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
tests for service/matching/handler/handler.go
Why?
improve unit test coverage
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes