Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] add new valid search attribute key cases for context header #6144

Merged

Conversation

shijiesheng
Copy link
Contributor

@shijiesheng shijiesheng commented Jun 24, 2024

What changed?

Allow "." and "-" in search attribute keys.

Why?

This is needed for indexing context header in search attributes

How did you test it?

Potential risks

Release notes

Documentation Changes

@shijiesheng shijiesheng changed the title [CLI] add new valid search attribute key cases for context header ind… [CLI] add new valid search attribute key cases for context header Jun 24, 2024
@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 01904b5e-fa94-443e-950d-c1952ed2ee13

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 33 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.007%) to 71.54%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.56%
common/task/fifo_task_scheduler.go 2 82.47%
service/matching/tasklist/matcher.go 2 90.91%
service/matching/tasklist/task_reader.go 2 77.72%
service/history/queue/timer_queue_processor_base.go 3 77.87%
common/persistence/statsComputer.go 3 98.21%
service/history/task/fetcher.go 3 86.6%
service/history/task/transfer_standby_task_executor.go 6 86.94%
service/history/queue/transfer_queue_processor.go 10 56.49%
Totals Coverage Status
Change from base Build 01903cd7-c1ac-49f3-a7a4-fe9da6c16ce7: 0.007%
Covered Lines: 106765
Relevant Lines: 149238

💛 - Coveralls

@shijiesheng shijiesheng merged commit 0b46176 into cadence-workflow:master Jun 25, 2024
19 checks passed
shijiesheng added a commit that referenced this pull request Jul 9, 2024
…ader indexing in visibility (#6144)"

This reverts commit 0b46176.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants