Handle not equal in custom keyword field #6185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
When operation is "!=" for a custom keyword type, use "and" clause instead of "or" clause to connect the queries.
Why?
Context: the reason why we used 2 queries and connect those with "or" is that a custom keyword field can be either a value or an array (a list).
Thus when it comes with a "!=" operation, it was not returning correct result, because the query results included unnecessary parts.
How did you test it?
unit test
manual test in Pinot
Potential risks
Release notes
Documentation Changes