Update Pinot query validator to support "like" in queries #6188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atch in system fields
sankari165
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
sankari165
removed request for
Groxx,
jakobht,
dkrotx,
taylanisikdemir,
davidporter-id-au,
3vilhamster,
shijiesheng,
Shaddoll,
agautam478 and
demirkayaender
sankari165
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bowenxia
reviewed
Jul 26, 2024
bowenxia
reviewed
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update pinot query validator to allow "like" in queries to support partial match for system fields like WorkflowID, RunID or WorkflowType
The PR also verifies that ES will not error out for a query with "like". It converts it to match_phrase since wild card is not supported in elasticsql as of now [https://github.com/cch123/elasticsql/blob/master/readme.md]
Why?
pinot supports partial match with text_match() and this can be leveraged in ListWorkflowExecutions. Based on earlier tests, text_match() performs better than regexp_like(). This does need text index in pinot
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes