Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more metrics for matching #6208

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Aug 5, 2024

What changed?
Add more metrics for matching

Why?
Improve observability

How did you test it?

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.93%. Comparing base (196d14b) to head (d606bec).
Report is 1 commits behind head on master.

Files Patch % Lines
service/matching/tasklist/matcher.go 66.66% 1 Missing ⚠️
service/matching/tasklist/task_list_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
service/matching/tasklist/forwarder.go 95.51% <100.00%> (+0.21%) ⬆️
service/matching/tasklist/matcher.go 78.80% <66.66%> (-1.00%) ⬇️
service/matching/tasklist/task_list_manager.go 66.91% <0.00%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196d14b...d606bec. Read the comment docs.

@Shaddoll Shaddoll merged commit a711217 into cadence-workflow:master Aug 5, 2024
20 checks passed
@Shaddoll Shaddoll deleted the forward-metrics branch August 5, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants