Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] update diagnostics workflow to return the result of diagnostics #6255

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

sankari165
Copy link
Member

What changed?
The workflow returns the issues identified, potential rootcause and a link to runbook

Why?
Diagnostics workflow performs the diagnostics on a w/f and should return the result collectively

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link
Member

@3vilhamster 3vilhamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Suggestion is to pull the development to the internal monorepo and merge back to OS once everything is tested on internal scenarios.

@sankari165 sankari165 enabled auto-merge (squash) August 27, 2024 12:17
@sankari165 sankari165 merged commit 824676f into cadence-workflow:master Aug 27, 2024
18 checks passed
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.01%. Comparing base (ac349fc) to head (c54420e).
Report is 2 commits behind head on master.

Files Patch % Lines
service/worker/diagnostics/workflow.go 77.77% 2 Missing ⚠️
Additional details and impacted files
Files Coverage Δ
service/worker/diagnostics/activities.go 100.00% <ø> (ø)
service/worker/diagnostics/workflow.go 88.57% <77.77%> (+1.47%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac349fc...c54420e. Read the comment docs.

@sankari165 sankari165 deleted the CDNC-10133 branch August 27, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants