Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] Set query handler for diagnostics workflow to provide result #6273

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

sankari165
Copy link
Member

What changed?
Diagnostics workflow has a query handler that provides the diagnostics result

Why?
Diagnostics workflow start will be triggered via api/cli and result will be fetched via query

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.09%. Comparing base (0a6ad93) to head (5a5277f).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
service/worker/diagnostics/workflow.go 73.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
service/worker/diagnostics/workflow.go 85.00% <73.33%> (-3.58%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a6ad93...5a5277f. Read the comment docs.

service/worker/diagnostics/workflow.go Outdated Show resolved Hide resolved
@sankari165 sankari165 merged commit 1771349 into cadence-workflow:master Sep 10, 2024
19 of 20 checks passed
@sankari165 sankari165 deleted the CDNC-10522 branch September 10, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants