Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce round robin load balancer to matching client #6300

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Introduce round robin load balancer to matching client #6300

merged 1 commit into from
Sep 26, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
Introduce round robin load balancer to matching client

Why?
Try new routing algorithms to improve latency for matching

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented Sep 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.22%. Comparing base (c8abc2a) to head (7fd4f7d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
client/matching/rb_loadbalancer.go 96.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
client/matching/multi_loadbalancer.go 100.00% <100.00%> (ø)
client/matching/rb_loadbalancer.go 96.66% <96.66%> (ø)

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8abc2a...7fd4f7d. Read the comment docs.

@davidporter-id-au
Copy link
Member

What is the theory by which this is expected to improve matching performance? I'm just not understanding what effect this might have ?

@Shaddoll
Copy link
Member Author

What is the theory by which this is expected to improve matching performance? I'm just not understanding what effect this might have ?
It also ensures even distribution, why bother not testing it?

taylanisikdemir
taylanisikdemir reviewed Sep 26, 2024
View reviewed changes
client/matching/rb_loadbalancer.go
@@ -0,0 +1,158 @@
// The MIT License (MIT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: shouldn't file name be rr_loadbalancer? :)

@Shaddoll Shaddoll merged commit c9c8c14 into cadence-workflow:master Sep 26, 2024
18 checks passed
@Shaddoll Shaddoll deleted the round-robin branch September 26, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylanisikdemir taylanisikdemir taylanisikdemir approved these changes

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shaddoll @davidporter-id-au @taylanisikdemir