Feature/zonal isolation zone discovery #6301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidporter-id-au
requested review from
Shaddoll,
neil-xie,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
| @@ -124,3 +127,15 @@ func Test_anyToString(t *testing.T) { | |||
| res := anyToString(info, false, 100) | |||
| assert.Equal(t, "{Name:Joel, Number:1234, Time:2019-01-15 14:30:45 +0000 UTC}", res) | |||
| } | |||
|
|
|||
| func TestJSONHistorySerializer_Serialize(t *testing.T) { | |||
There was a problem hiding this comment.
just added because I needed more test coverage
Shaddoll
reviewed
Oct 3, 2024
Shaddoll
approved these changes
Oct 3, 2024
davidporter-id-au
merged commit f8d70de
into
cadence-workflow:master
19 of 20 checks passed
Shaddoll
added a commit
to Shaddoll/cadence
that referenced
this pull request
Oct 15, 2024
This reverts commit f8d70de.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This changes the config property
system.AllIsolationGroupsfrom being a fixed static configuration value loaded on startup to be a callback which can be updated more dynamically. This should continue working with the existing dynamic config property as before, but support passing in a more complex discovery mechanism for isolation groups as needed.Why?
We found that we were having trouble updating this config in production and needed to refactor it slightly to allow for a better update system.
How did you test it?
Deployed in staging environments with some initial manual testing as well as the unit testing.
Potential risks
This could break zonal isolation-the feature if it is wrong or buggy. that feature is designed to fall back to tasks being simply un-isolated, so it's not expected to actually break task processing, but it could degrade it if it were to contain some unforseen problems.
Release notes