-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinot handle customer keyword type empty val #6302
Pinot handle customer keyword type empty val #6302
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -115,7 +115,7 @@ func TestValidateQuery(t *testing.T) { | |||
}, | |||
"Case8-4: query with custom keyword field not equal": { | |||
query: "CustomKeywordField != 0", | |||
validated: "JSON_MATCH(Attr, '\"$.CustomKeywordField\"!=''0''') and JSON_MATCH(Attr, '\"$.CustomKeywordField[*]\"!=''0''')", | |||
validated: "(JSON_MATCH(Attr, '\"$.CustomKeywordField\"!=''0''') and JSON_MATCH(Attr, '\"$.CustomKeywordField[*]\"!=''0'''))", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit consider using backticks to make things more readable when fighting quotes in quites
ie
`(JSON_MATCH(Attr, '"$.CustomKeywordField"!=''0''') and JSON_MATCH(Attr, '"$.CustomKeywordField[*]"!=''0'''))`
I guess, or similar, I'm having slight trouble following this because I've not spent enough time close to the Pinot component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do in the next PR. I enabled auto-merge for this one
* add query to handle empty keyword val
What changed?
Why?
How did you test it?
unit test, manually test in Pinot
Potential risks
Release notes
Documentation Changes