[Wf-Diagnostics] introduce emitter interface in w/f diagnostics #6309
Conversation
sankari165
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| msg[DiagnosticsStartTime] = data.DiagnosticsStartTime | ||
| msg[DiagnosticsEndTime] = data.DiagnosticsEndTime | ||
|
|
||
| serializedMsg, err := json.Marshal(msg) |
There was a problem hiding this comment.
why not just serialize WfDiagnosticsUsageData? It that to have some compatibility?
There was a problem hiding this comment.
am following whats done in visibility. will double check with Neil too
| return err | ||
| } | ||
|
|
||
| pinotMsg := &indexer.PinotMessage{ |
There was a problem hiding this comment.
shouldn't this layer be visibility-store agnostic?
What changed?
Workflow Diagnostics has a emitter interface that produces messages to a kafka topic
Why?
this emitter will be used to emit usage logs from workflow diagnostics runs to a pinot table
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes