Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] Introduce Diagnostics starter workflow as parent workflow to run diagnostics #6310

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

sankari165
Copy link
Member

What changed?
diagnostics workflow will run as child workflow within a starter parent workflow that will be triggered by frontend api

Why?
the parent workflow starts and waits for diagnostics to complete and then will execute an activity (will be added in future PR) to emit usage logs into kafka

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.21%. Comparing base (71cf16a) to head (c4d0860).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
service/worker/diagnostics/parent_workflow.go 73.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
service/frontend/api/handler.go 65.97% <100.00%> (ø)
service/worker/diagnostics/module.go 100.00% <100.00%> (ø)
service/worker/diagnostics/workflow.go 82.45% <100.00%> (+0.94%) ⬆️
service/worker/diagnostics/parent_workflow.go 73.33% <73.33%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71cf16a...c4d0860. Read the comment docs.

return DiagnosticsStarterWorkflowResult{DiagnosticsResult: &result}, nil
})
if err != nil {
return nil, err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wrap this error as well?

@sankari165 sankari165 merged commit 4424df7 into cadence-workflow:master Sep 27, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-10485-parent-wf branch September 27, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants