Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in Describe handler #6312

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
Deep copy maps in describe handler

Why?
To avoid concurrent read/write map, because we do some type conversion in Thrift/Grpc handler when the maps are not protected by any lock.

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.26%. Comparing base (7b6846d) to head (c4a4ebc).
Report is 4 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
common/persistence/data_manager_interfaces.go 96.03% <100.00%> (+0.55%) ⬆️
...y/engine/engineimpl/describe_workflow_execution.go 79.03% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b6846d...c4a4ebc. Read the comment docs.

@Shaddoll Shaddoll merged commit 02984fd into cadence-workflow:master Sep 27, 2024
20 checks passed
@Shaddoll Shaddoll deleted the desc branch September 27, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants