Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wf-Diagnostics] add timeout error to failures #6346

Merged

Conversation

sankari165
Copy link
Member

What changed?
add timeout error to failures

Why?
when an activity times out and as a result, a workflow fails, it throws a timeout error which is not the same as workflow timeout

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.72%. Comparing base (74ec9b1) to head (5a8d0b4).
Report is 2 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
...ce/worker/diagnostics/invariant/failure/failure.go 92.68% <100.00%> (+0.37%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ec9b1...5a8d0b4. Read the comment docs.

@sankari165 sankari165 merged commit c8f19c0 into cadence-workflow:master Oct 9, 2024
20 checks passed
@sankari165 sankari165 deleted the CDNC-10787-rootcause branch October 10, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants