Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for types/mapper/thrift/admin.go #6352

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

natemort
Copy link
Member

What changed?

  • Add unit tests for types/mapper/thrift/admin.go . This is mostly just a copy+paste of the unit tests I previously wrote for the proto mappers. Since they round trip from the internal types and have functions with the same name they work out perfectly.

Why?

  • Increase unit test coverage

How did you test it?

  • Running unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.13%. Comparing base (073508e) to head (8614f2c).
Report is 10 commits behind head on master.

Additional details and impacted files

see 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073508e...8614f2c. Read the comment docs.

Copy link
Member

@timl3136 timl3136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natemort natemort merged commit 0a52b25 into cadence-workflow:master Oct 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants