Add tests for recursive types in defaulter-gen #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
reviewed
Jun 12, 2017
| @@ -38,3 +38,19 @@ type Struct_No_Field_Has_Manual_Defaulter struct { | |||
| TypeMeta struct{} | |||
| OtherField string | |||
| } | |||
|
|
|||
| // Struct_A_Has_Manual_Defaulter has recursive types structA and structB | |||
| type Struct_A_Has_Manual_Defaulter struct { | |||
There was a problem hiding this comment.
how about Recursive_Struct_A_With_Manual_Defaulter ? Same for B.
nikhita
force-pushed
the
nikhita-recursive-types-test
branch
from
28b2fad to
4820e8e
Compare
|
Updated and addressed comments. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for defaulter-gen to support recursive types is here: kubernetes#61.
This commit adds tests for it. The tests should pass once kubernetes#61 is merged.
/cc @sttts