-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 8.x and Php 8.0 Support, fixes #8
Conversation
@kaidesu Hi, maybe you has no time, but its a new bug the last merge |
What's the use case for the add directive? This is meant to programmatically add assets to your application from the backend. For the frontend, you load your assets natively. |
@kaidesu of course in front end i can load my assets natively, but i'm using json files and need to load dinamically on blade views(i don´t wanna use |
I would argue that belongs in a view composer 👍 then you can natively use Bonsai as intended without muddying up your view files. I'll accept this PR if you remove the |
They are partial views added with |
@kaidesu ping :) |
@kaidesu ready for merge, tested in Laravel 8.32 and PHP 8.0.2 |
Added blade directive add,example@bonsai('add','files.bonsai.json')
also removed unnecessary breaks;
and " ' " from casesCloses #7
(sorry for my english)