-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django1.7 compatibility #93
Django1.7 compatibility #93
Conversation
This reverts commit 3b7ebe9.
Sorry didn't mean to open and close that, thought i'd missed a commit but it was just in reverse order |
👍 on merging this; I'll close #102 in favor of this one. ✨ |
@glassresistor can you add this to to from django import VERSION as DJANGO_VERSION
# Use DiscoverRunner on Django 1.7 and above
if DJANGO_VERSION[0] == 1 and DJANGO_VERSION[1] >= 7:
TEST_RUNNER = 'django.test.runner.DiscoverRunner' |
yes i'll do that now! On Sat, Sep 20, 2014 at 5:27 PM, Beau Gunderson notifications@github.com
Mikela |
Ok done reran tests still pass |
@glassresistor thanks for all the work. In case of my project I needed to patch deserialize method too, but I'm not sure if it breaks Django 1.6 compatibility (so no pull request): jurecuhalev@85a531d |
@gandalfar thanks for the heads up, since that didn't cause a failing test we should probably getting failing test first |
Thanks for the work guys. Would any of you be interested in getting a fork of this going so that we can get some other PRs merged? Maybe we create a separate org for it and spread ownership so that there's less likelihood of things getting stale. I think @peterldowns was interested in getting his work on djoauth2 merged together too. |
I think thats an amazing idea in terms of making this an organization having some collaborators. I'm doing this for work and pretty sure we wouldn't mind tracking this. I'd like to work on getting a real security audit at some point and organizing afew more people with commit access and putting in place styleguides, rules for making a PR, and better test coverage is probably a good start. |
@gandalfar @peterldowns @eculver @beaugunderson @caffeinehit any of you care to meetup in irc or something and chat on this subject I prefer to be make sure everyone is down for the doing something like that |
@eculver @glassresistor I would love to help out, or at least talk about the idea of helping out. My own OAuth project (djouath2), while still functional, has become stagnant since I left my job, but I think the need for a great OAuth package in the Django community is still high. What's the best way to schedule a time for all of us to chat on IRC? |
IRC works for me. I'm eculver on Freenode. I went ahead and created a #django-oauth2-provider channel. I'll be in there if/when people want to discuss. If anyone wants to suggest an alternative, I'm all ears. |
@eculver @peterldowns sorry i ended up vacationing right after i started this chat, i've started lurking in chat. hit me here next time your on |
Heya, Any progress on this ? |
I totally messed up by skipping town for a week. I'll merge this stuff On Sun, Nov 2, 2014 at 4:48 AM, Antoine Hedgecock notifications@github.com
Mikela |
Did this fork get created? If not and others can help, just shout. |
No sorry. I can do it soon but keep lossing traction and mean to do On Thu, Dec 4, 2014 at 2:42 AM, btnz notifications@github.com wrote:
Mikela |
Any progress on this? |
Thanks for the work so far! I could also really use this. Please let me know if there is any way to speed up things. |
Nice to see the initiative on bringing this back to life. Hope to hear some more :). |
bump. any progress/help needed to get this going? |
As a temporary workaround for local development you can install directly from glassresistor's repo in a virtual env: $ workon yourvirtalenv However, correct me if I'm wrong, but I don't believe this will work when deploying to something like Cloud Foundry, since you can't convey this via the requirements.txt. |
You could host this in your own repo, and configure requirements to use editable packages. Search for the word editable on this page. It's far from ideal, but if you need requirements.txt to work, this should probably achieve that. https://pip.pypa.io/en/1.1/requirements.html I'm going to have to do this myself I think as there doesn't appear to be any movement with this |
Alternatively, this also seems to provide oauth2, and it claims to be 1.7 compatible: https://github.com/evonove/django-oauth-toolkit |
You can totally have a git repository in a requirements.txt in this case use the zip file i made here
If you want to use the git repo itself
|
@glassresistor - Thanks for the zip file option, I think most of us are just trying to figure out what the future is of this in any official sense. Are you still going to fork it? Should somebody else do this if you're too busy? @jeroenvlek - Thanks for that, worth looking at if it's an active alternative, so I'll check it out. |
My plan is use the other lib unless i have to fork this one. I'm using On Fri, Dec 19, 2014 at 1:49 AM, btnz notifications@github.com wrote:
Mikela |
Please use https://github.com/evonove/django-oauth-toolkit its much better and has more support. Works with django restframework and should be adaptable to anything else. I don't believe I have a reason to support this library now(which is great). |
I have merged this on my fork |
I've gone through and made this Django 1.7 compatible. The tests pass on multiple machines.
Its changed how it handled nest packages so I've had to manually set db_table and app_label in models.
Django no longer supports python 2.6 so i've removed it from tox.