Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django1.7 compatibility #93

Merged
merged 12 commits into from
Feb 3, 2023

Conversation

glassresistor
Copy link
Contributor

I've gone through and made this Django 1.7 compatible. The tests pass on multiple machines.
Its changed how it handled nest packages so I've had to manually set db_table and app_label in models.
Django no longer supports python 2.6 so i've removed it from tox.

@glassresistor
Copy link
Contributor Author

Sorry didn't mean to open and close that, thought i'd missed a commit but it was just in reverse order

@beaugunderson
Copy link

👍 on merging this; I'll close #102 in favor of this one. ✨

@beaugunderson
Copy link

@glassresistor can you add this to to tests/settings.py? It will stop the warnings shown during tests.

from django import VERSION as DJANGO_VERSION

# Use DiscoverRunner on Django 1.7 and above
if DJANGO_VERSION[0] == 1 and DJANGO_VERSION[1] >= 7:
    TEST_RUNNER = 'django.test.runner.DiscoverRunner'

@glassresistor
Copy link
Contributor Author

yes i'll do that now!

On Sat, Sep 20, 2014 at 5:27 PM, Beau Gunderson notifications@github.com
wrote:

@glassresistor https://github.com/glassresistor can you add this to to
tests/settings.py? It will stop the warnings shown during tests.

Use DiscoverRunner on Django 1.7 and aboveif DJANGO_VERSION[0] == 1 and DJANGO_VERSION[1] >= 7:

TEST_RUNNER = 'django.test.runner.DiscoverRunner'


Reply to this email directly or view it on GitHub
#93 (comment)
.

Mikela

@glassresistor
Copy link
Contributor Author

Ok done reran tests still pass

@jurecuhalev
Copy link

@glassresistor thanks for all the work. In case of my project I needed to patch deserialize method too, but I'm not sure if it breaks Django 1.6 compatibility (so no pull request): jurecuhalev@85a531d

@glassresistor
Copy link
Contributor Author

@gandalfar thanks for the heads up, since that didn't cause a failing test we should probably getting failing test first

@eculver
Copy link
Contributor

eculver commented Sep 30, 2014

Thanks for the work guys. Would any of you be interested in getting a fork of this going so that we can get some other PRs merged? Maybe we create a separate org for it and spread ownership so that there's less likelihood of things getting stale. I think @peterldowns was interested in getting his work on djoauth2 merged together too.

@glassresistor
Copy link
Contributor Author

I think thats an amazing idea in terms of making this an organization having some collaborators. I'm doing this for work and pretty sure we wouldn't mind tracking this. I'd like to work on getting a real security audit at some point and organizing afew more people with commit access and putting in place styleguides, rules for making a PR, and better test coverage is probably a good start.
I'll see about adding in @gandalfar 's changes and a failing test if I can get to it today.

@glassresistor
Copy link
Contributor Author

@gandalfar @peterldowns @eculver @beaugunderson @caffeinehit any of you care to meetup in irc or something and chat on this subject I prefer to be make sure everyone is down for the doing something like that
in general i think this has been a well maintained lib and would therefore like

@peterldowns
Copy link

@eculver @glassresistor I would love to help out, or at least talk about the idea of helping out. My own OAuth project (djouath2), while still functional, has become stagnant since I left my job, but I think the need for a great OAuth package in the Django community is still high. What's the best way to schedule a time for all of us to chat on IRC?

@eculver
Copy link
Contributor

eculver commented Oct 6, 2014

IRC works for me. I'm eculver on Freenode. I went ahead and created a #django-oauth2-provider channel. I'll be in there if/when people want to discuss. If anyone wants to suggest an alternative, I'm all ears.

@glassresistor
Copy link
Contributor Author

@eculver @peterldowns sorry i ended up vacationing right after i started this chat, i've started lurking in chat. hit me here next time your on

@macnibblet
Copy link

Heya, Any progress on this ?

@glassresistor
Copy link
Contributor Author

I totally messed up by skipping town for a week. I'll merge this stuff
together and make a new "official" fork and start taking PRs

On Sun, Nov 2, 2014 at 4:48 AM, Antoine Hedgecock notifications@github.com
wrote:

Heya, Any progress on this ?


Reply to this email directly or view it on GitHub
#93 (comment)
.

Mikela

@btnz
Copy link

btnz commented Dec 4, 2014

Did this fork get created? If not and others can help, just shout.

@glassresistor
Copy link
Contributor Author

No sorry. I can do it soon but keep lossing traction and mean to do
somemore cleanup.

On Thu, Dec 4, 2014 at 2:42 AM, btnz notifications@github.com wrote:

Did this fork get created?


Reply to this email directly or view it on GitHub
#93 (comment)
.

Mikela

@valberg
Copy link

valberg commented Dec 11, 2014

Any progress on this?

@jeroenvlek
Copy link

Thanks for the work so far! I could also really use this. Please let me know if there is any way to speed up things.

@timo-piirmann
Copy link

Nice to see the initiative on bringing this back to life. Hope to hear some more :).

@kleinlieu
Copy link

bump. any progress/help needed to get this going?

@jeroenvlek
Copy link

As a temporary workaround for local development you can install directly from glassresistor's repo in a virtual env:

$ workon yourvirtalenv
$ pip install git+git://github.com/glassresistor/django-oauth2-provider.git

However, correct me if I'm wrong, but I don't believe this will work when deploying to something like Cloud Foundry, since you can't convey this via the requirements.txt.

@btnz
Copy link

btnz commented Dec 15, 2014

You could host this in your own repo, and configure requirements to use editable packages. Search for the word editable on this page. It's far from ideal, but if you need requirements.txt to work, this should probably achieve that.

https://pip.pypa.io/en/1.1/requirements.html

I'm going to have to do this myself I think as there doesn't appear to be any movement with this

@jeroenvlek
Copy link

Alternatively, this also seems to provide oauth2, and it claims to be 1.7 compatible: https://github.com/evonove/django-oauth-toolkit

@glassresistor
Copy link
Contributor Author

You can totally have a git repository in a requirements.txt in this case use the zip file i made here
example requirements.txt:

django
https://github.com/glassresistor/django-oauth2-provider/archive/stable.zip

If you want to use the git repo itself

-e git+https://github.com/glassresistor/django-oauth2-provider.git#egg=django-oauth2-provider

@btnz
Copy link

btnz commented Dec 19, 2014

@glassresistor - Thanks for the zip file option, I think most of us are just trying to figure out what the future is of this in any official sense. Are you still going to fork it? Should somebody else do this if you're too busy?

@jeroenvlek - Thanks for that, worth looking at if it's an active alternative, so I'll check it out.

@glassresistor
Copy link
Contributor Author

My plan is use the other lib unless i have to fork this one. I'm using
restframework and am spending the holidays figuring out what a good
decision is. Anyone doing work on oauth right now i'll totally QA and
merge into my fork but yes I'm stretched for time.

On Fri, Dec 19, 2014 at 1:49 AM, btnz notifications@github.com wrote:

@glassresistor https://github.com/glassresistor - Thanks for the zip
file option, I think most of us are just trying to figure out what the
future is of this in any official sense. Are you still going to fork it?
Should somebody else do this if you're too busy?

@jeroenvlek https://github.com/jeroenvlek - Thanks for that, worth
looking at if it's an active alternative, so I'll check it out.


Reply to this email directly or view it on GitHub
#93 (comment)
.

Mikela

@glassresistor
Copy link
Contributor Author

Please use https://github.com/evonove/django-oauth-toolkit its much better and has more support. Works with django restframework and should be adaptable to anything else.

I don't believe I have a reason to support this library now(which is great).

@skruger
Copy link
Contributor

skruger commented Mar 9, 2015

I have merged this on my fork
stormsherpa#1

@andy-a andy-a merged commit 9cc1a95 into caffeinehit:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.