Fix OneBusAway#943 Workaround for String.isEmpty() being broken in ne…

…wer versions of Gradle
cagryInside · Jun 27, 2019 · 9b300d5 · 9b300d5
1 parent 036bdd8
commit 9b300d5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...ay-android/src/main/java/org/onebusaway/android/travelbehavior/TravelBehaviorManager.java b/...ay-android/src/main/java/org/onebusaway/android/travelbehavior/TravelBehaviorManager.java
@@ -240,7 +240,6 @@ private void registerUser(String email) {
         Futures.addCallback(listenableFuture, new FutureCallback<WorkInfo>() {
             @Override
             public void onSuccess(@NullableDecl WorkInfo result) {
-                startCollectingData();
                 Activity activity = (Activity) mActivityContext;
                 activity.runOnUiThread(() -> Toast.makeText(mApplicationContext, R.string.travel_behavior_enroll_success,
                         Toast.LENGTH_LONG).show());

diff --git a/.../onebusaway/android/travelbehavior/io/worker/RegisterTravelBehaviorParticipantWorker.java b/.../onebusaway/android/travelbehavior/io/worker/RegisterTravelBehaviorParticipantWorker.java
@@ -64,7 +64,7 @@ private void registerUser() {
         TravelBehaviorFileSaverExecutorManager manager =
                 TravelBehaviorFileSaverExecutorManager.getInstance();
         auth.signInAnonymously()
-                .addOnCompleteListener(task -> {
+                .addOnCompleteListener(manager.getThreadPoolExecutor(), task -> {
                     if (task.isSuccessful()) {
                         Log.v(TAG, "Firebase user init success ID: " + auth.getUid());
                         saveEmailAddress(auth.getUid());
@@ -85,6 +85,7 @@ private void saveEmailAddress(String uid) {
             String result = IOUtils.toString(reader);
             if (TravelBehaviorConstants.PARTICIPANT_SERVICE_RESULT.equals(result)) {
                 TravelBehaviorManager.optInUser(uid);
+                TravelBehaviorManager.startCollectingData(getApplicationContext());
                 mFuture.set(Result.success());
             } else {
                 mFuture.set(Result.failure());

diff --git a/onebusaway-android/src/main/java/org/onebusaway/android/util/EmbeddedSocialUtils.java b/onebusaway-android/src/main/java/org/onebusaway/android/util/EmbeddedSocialUtils.java
@@ -137,7 +137,7 @@ public static boolean isBuildVersionSupportedBySocial() {
      */
     public static boolean isSocialApiKeyDefined() {
         String embeddedSocialApiKey = BuildConfig.EMBEDDED_SOCIAL_API_KEY;
-        return embeddedSocialApiKey != null && !embeddedSocialApiKey.isEmpty();
+        return embeddedSocialApiKey != null && embeddedSocialApiKey.length() != 0;
     }
 
     /**