Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1315): update golangci-lint version for memory usage #1316

Merged
merged 4 commits into from
Oct 31, 2019
Merged

fix(1315): update golangci-lint version for memory usage #1316

merged 4 commits into from
Oct 31, 2019

Conversation

supereagle
Copy link
Member

What this PR does / why we need it:

Add your description

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #1315

Reference to #

Special notes for your reviewer:

/cc @zhujian7

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2019
@caicloud-bot caicloud-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2019
zhujian7
zhujian7 reviewed Oct 24, 2019
View reviewed changes
.golangci.yml Outdated
linters-settings:
misspell:
ignore-words:
- noteable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notable?

Copy link
Member Author

@supereagle supereagle Oct 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a miss spelling error of MergeCommentEvent struct in pkg/server/biz/scm/gitlab/gitlab.go#L311-L350, this struct is copied from Gitlab. It can not be fixed by us, so we have to ignore this error.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field maybe is useless for us, could we delete it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have deleted

@caicloud-bot caicloud-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2019
@zhujian7
Copy link
Collaborator

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@caicloud-bot caicloud-bot merged commit 064d160 into caicloud:master Oct 31, 2019
@zhujian7
Copy link
Collaborator

/cherrypick cps-2.9

@caicloud-bot caicloud-bot mentioned this pull request Feb 19, 2020
Merged
@caicloud-bot
Copy link
Collaborator

@zhujian7: new pull request created: #1388

In response to this:

/cherrypick cps-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhujian7 zhujian7 zhujian7 left review comments

Assignees

@zhujian7 zhujian7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update golangci-lint version for memory usage
3 participants
@supereagle @zhujian7 @caicloud-bot