wip:refactor: refactor retry logic of creating pod failed #1342
Conversation
caicloud-bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
caicloud-bot
added
the
size/XL
The old logic will make controller stuck for a long time
|
/hold |
caicloud-bot
added
the
do-not-merge/hold
| // executed but not succeeded for some retryable reason. | ||
| type RetryStatus struct { | ||
| // Times records the execution times, e.g. 1 represents the first time to execute. | ||
| Times int `json:"times,omitempty"` |
| // RetryConfig configures retry times and duration for retrying to execute a stage. | ||
| type RetryConfig struct { | ||
| // Times of a stage can be totally retried | ||
| Times int `json:"times"` |
There was a problem hiding this comment.
The fields are not clear, what about:
type RetryConfig struct {
// Limit defines the max retry times of one stage execution.
Limit int `json:"limit"`
// Timeout defines the retry timeout of one stage execution.
Timeout time.Duration `json:"Timeout"`
|
@zhujian7: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
#1528 fixed this problem |
What this PR does / why we need it:
The old retry logic will make the controller stuck for a long time, delete it.
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @your-reviewer
Release note: