Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete project name in workflow pod env #1509

Merged
merged 1 commit into from
Oct 15, 2020
Merged

fix: delete project name in workflow pod env #1509

merged 1 commit into from
Oct 15, 2020

Conversation

zhujian7
Copy link
Collaborator

@zhujian7 zhujian7 commented Oct 14, 2020 •
edited
Loading

PROJECT_NAME is a very likely conflict word with other systems,
like ourselves SonarQube scanner program，do not inject it as an
Env into the WorkflowRun pod.

TODO:

  • change the Env key name(add a prefix like CYCLONE_PROJECT_NAME)
    and inject it in the future.

What this PR does / why we need it:

PROJECT_NAME is in conflict with https://github.com/caicloud/cyclone/blob/cps-2.10/build/cicd/sonarqube/entrypoint.sh#L13

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to ##1506

Special notes for your reviewer:

/cc @hyy0322 @supereagle

Release note:

NONE

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. labels Oct 14, 2020
@zhujian7
fix: delete project name in workflow pod env
13fd120 
PROJECT_NAME is a very likely conflict word with other systems,
like ourselves SonarQube scanner program，do not inject it as an
Env into the WorkflowRun pod.

TODO:
- change the Env key name(add a prefix like CYCLONE_PROJECT_NAME)
and inject it in the future.
@zhujian7
Copy link
Collaborator Author

/cherrypick cps-2.10-dood

@caicloud-bot
Copy link
Collaborator

@zhujian7: once the present PR merges, I will cherry-pick it on top of cps-2.10-dood in a new PR and assign it to you.

In response to this:

/cherrypick cps-2.10-dood

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hyy0322
Copy link
Contributor

hyy0322 commented Oct 15, 2020

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2020
@zhujian7
Copy link
Collaborator Author

/approve

@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hyy0322, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2020
@caicloud-bot caicloud-bot merged commit 9f145c8 into caicloud:cps-2.10 Oct 15, 2020
@caicloud-bot caicloud-bot mentioned this pull request Oct 15, 2020
Merged
@caicloud-bot
Copy link
Collaborator

@zhujian7: new pull request created: #1510

In response to this:

/cherrypick cps-2.10-dood

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zhujian7 added a commit to zhujian7/cyclone that referenced this pull request Oct 15, 2020
@zhujian7
fix: delete project name in workflow pod env
06edc85 
cherry-pick: caicloud#1509
@zhujian7 zhujian7 mentioned this pull request Oct 15, 2020
Merged
caicloud-bot pushed a commit that referenced this pull request Nov 5, 2020
@zhujian7
fix: add workflow and project name info for pods created by cyclone (#…
f4226eb 
…1507)

* fix: add workflow nnd project name info for pods created by cyclone (#1506)

* fix: delete project name in workflow pod env

cherry-pick: #1509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hyy0322 hyy0322

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhujian7 @caicloud-bot @hyy0322