Make coordinator independent of docker #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 12, 2020 14:27
caicloud-bot
added
release-note
zhujian7
reviewed
Nov 16, 2020
| @@ -452,6 +461,11 @@ func (m *Builder) ResolveInputResources() error { | |||
| Name: common.ToolsVolume, | |||
| MountPath: common.ToolboxPath, | |||
| }, | |||
| { | |||
| Name: common.CoordinatorSidecarVolumeName, | |||
There was a problem hiding this comment.
Why does input container need this volume?
pkg/workflow/workload/pod/builder.go
Outdated
| MountPath: common.DockerSockFilePath, | ||
| Name: common.CoordinatorSidecarVolumeName, | ||
| MountPath: filepath.Join(common.CoordinatorWorkspacePath, "results"), | ||
| SubPath: "__results__", |
There was a problem hiding this comment.
Hold the __results__ as a common const var?
|
/ok-to-test |
|
/cc @zhujian7 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
caicloud-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
__result__file to/cyclone/results/__result__Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @zhujian7
Release note: