fix(#252;#258): ensure terminating worker with error before delete fail event #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get workerInfo before worker.Do()
supereagle
reviewed
Nov 30, 2017
| @@ -242,6 +241,9 @@ func createVersionHandler(event *api.Event) error { | |||
| return err | |||
| } | |||
|
|
|||
| // set worker info to event | |||
| event.Worker = worker.GetWorkerInfo() | |||
There was a problem hiding this comment.
Also need to change createServiceHandler()
|
Can one of the admins verify this patch? |
LiangXugang
changed the title
LiangXugang
changed the title
This was referenced Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ISSUE-252 ISSUE-258
Changes
Reviewers
Checklist