fix(#278): check token when creat/update project with token #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
token should has authority of repo
|
Can one of the admins verify this patch? |
LiangXugang
changed the title
supereagle
reviewed
Dec 9, 2017
| } | ||
| case api.SVN: | ||
| return fmt.Errorf("SCM %s is not supported", scmType) | ||
| default: | ||
| return fmt.Errorf("SCM type %s is unknow", scmType) | ||
| } | ||
|
|
||
| // Update the token if generate a new one. | ||
| config.Token = token |
There was a problem hiding this comment.
Add a new variable generatedToken for generated token, and check its value here. If it is empty, then check the token of the config, otherwise set the generated token to the config. What about this implementation?
supereagle
reviewed
Dec 9, 2017
If oauth type is token, use private-token client instead of oauth2.0 token client
LiangXugang
changed the title
supereagle
approved these changes
Dec 12, 2017
supereagle
pushed a commit
to supereagle/cyclone
that referenced
this pull request
Dec 12, 2017
…aicloud#280) * fix(caicloud#278): check token when creat/update project with token token should has authority of repo * fix(caicloud#278): check token when creat/update project with token * fix(caicloud#278): check token when creat/update project with token If oauth type is token, use private-token client instead of oauth2.0 token client * refactor: generate token with password or check token * refactor: check gitlab token
2 tasks
supereagle
added a commit
that referenced
this pull request
Dec 13, 2017
) * fix(#278): check token when creat/update project with token token should has authority of repo * fix(#278): check token when creat/update project with token * fix(#278): check token when creat/update project with token If oauth type is token, use private-token client instead of oauth2.0 token client * refactor: generate token with password or check token * refactor: check gitlab token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ISSUE-278
Changes
Check whether the token has authority of repo when create/update project with token
Reviewers
@supereagle please review
Checklist