Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default version.name(version.versionID) #303

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

LiangXugang
Copy link

default name when codeCheckout failed

Fixes ISSUE-XXX

Changes

  • default name (versionID) when codeCheckout failed

Reviewers

Checklist

  • Rebased/mergable
  • Tests pass
  • Issue/task done

default name when codeCheckout failed
@caicloud-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@supereagle supereagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supereagle supereagle merged commit 88b7d2a into caicloud:v1-preview Jan 3, 2018
supereagle pushed a commit to supereagle/cyclone that referenced this pull request Jan 4, 2018
supereagle added a commit that referenced this pull request Jan 4, 2018
@LiangXugang LiangXugang deleted the versionName branch January 5, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants