Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #331 into release-0.3 #364

Merged
merged 1 commit into from
Mar 4, 2018

Conversation

supereagle
Copy link
Member

What this PR does / why we need it:

Manually cherry pick #331 into release-0.3:
#331: fix(#330): fix panic error when abort pipeline which has no log

Which issue(s) this PR fixes (optional, close the issue(s) when PR gets merged):

Fixes #330

Special notes for your reviewer:

/cc @zhujian7

Release note:

NONE

@caicloud-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2018
@supereagle supereagle changed the title fix(#330): fix panic error when abort pipeline which has no log Cherry pick #331 into release-0.3 Mar 2, 2018
@zhujian7
Copy link
Collaborator

zhujian7 commented Mar 2, 2018

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2018
@supereagle
Copy link
Member Author

/approve

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2018
@caicloud-bot caicloud-bot added the caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. label Mar 4, 2018
@caicloud-bot
Copy link
Collaborator

/lgtm cancel //PR changed after LGTM, removing LGTM. @supereagle @zhujian7

@caicloud-bot caicloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2018
@bbbmj
Copy link
Member

bbbmj commented Mar 4, 2018

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2018
@caicloud-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbbmj, supereagle, zhujian7

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@caicloud-bot
Copy link
Collaborator

Automatic merge from submit-queue.

@caicloud-bot caicloud-bot merged commit c277670 into caicloud:release-0.3 Mar 4, 2018
@supereagle supereagle deleted the cherry-pick-331 branch December 23, 2018 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants