Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH4018 GH4019: TeamCity Messages Enhancements #3994

Merged
merged 2 commits into from
Oct 25, 2022
Merged

GH4018 GH4019: TeamCity Messages Enhancements #3994

merged 2 commits into from
Oct 25, 2022

Conversation

BlythMeister
Copy link
Contributor

@BlythMeister BlythMeister commented Oct 18, 2022 •
edited by gep13
Loading

  • Add function which sends the the build statistic servie message to TeamCity
  • Add function to build status message with status to TeamCity (Append to existing, Prepend, or replace)

Fix: #4018
Fix: #4019

@BlythMeister BlythMeister changed the title Add support to write TeamCity statistics TeamCity Messages Fixes/Enhancements Oct 18, 2022
@BlythMeister BlythMeister marked this pull request as draft October 18, 2022 13:37
@BlythMeister BlythMeister marked this pull request as ready for review October 18, 2022 13:48
@BlythMeister BlythMeister changed the title TeamCity Messages Fixes/Enhancements TeamCity Messages Enhancements Oct 18, 2022
augustoproiete
augustoproiete approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gep13
Copy link
Member

gep13 commented Oct 20, 2022

@BlythMeister is there an issue associated with this PR? i.e. was this change already discussed somewhere?

@BlythMeister
Copy link
Contributor Author

Oh no there isn't one. It's just a couple of message types that TeamCity supports but cake doesn't.
I can raise an issue to go with this if needed?

@gep13
Copy link
Member

gep13 commented Oct 20, 2022

@BlythMeister said...
I can raise an issue to go with this if needed?

Yes, if you could, that would be appreciated. This will mean that the issue can be assigned to the next milestone, and ideally, the commit messages in this PR would be updated to mention the issue, so that there is complete traceability for the changes.

@BlythMeister
Copy link
Contributor Author

Ok, no worries, I'll make the changes before the weekend and raise the linked issue.

@BlythMeister
Copy link
Contributor Author

@gep13 discussions raised (#4002 and #4003)

@BlythMeister BlythMeister marked this pull request as draft October 21, 2022 00:48
@BlythMeister BlythMeister reopened this Oct 21, 2022
@BlythMeister BlythMeister marked this pull request as ready for review October 21, 2022 10:13
@BlythMeister
Copy link
Contributor Author

@augustoproiete @gep13 This should be ready now with 2 issues (for some reason i can't get them to link) and the commits have the hash for them in too :)

@BlythMeister BlythMeister force-pushed the teamcity branch 2 times, most recently from 74e38cd to 979619d Compare October 21, 2022 13:05
@BlythMeister
Copy link
Contributor Author

not sure what's going on with the build failure, but doesn't look related

@devlead devlead force-pushed the teamcity branch 2 times, most recently from 044c260 to 31c58db Compare October 24, 2022 22:39
@gep13
Copy link
Member

gep13 commented Oct 25, 2022

@BlythMeister can you please see the message above regarding the CLA? Is this something that you are in a position to sign?

@gep13
Copy link
Member

gep13 commented Oct 25, 2022

@BlythMeister I have taken the liberty of making changes to your commit messages. You created two discussions, when what we normally make use of are issues. I have converted your discussions to issues, and I have updated the commit messages to point to the new issues.

Let me know if you have any questions.

@BlythMeister
Copy link
Contributor Author

@microsoft-github-policy-service agree

@gep13
Copy link
Member

gep13 commented Oct 25, 2022

@BlythMeister said...
not sure what's going on with the build failure, but doesn't look related

Due to the rebase, the CI builds are being kicked off again, so we can see if things build this time.

@BlythMeister
Copy link
Contributor Author

@gep13 I thought I already had when I contributed here before.

@gep13
Copy link
Member

gep13 commented Oct 25, 2022

@BlythMeister said...
I thought I already had when I contributed here before.

I believe that there has been a change to the CLA bot that we are making use of on this repository, as @devlead also had to sign it recently again. I don't have any other details on this at the minute though.

@BlythMeister
Copy link
Contributor Author

@BlythMeister I have taken the liberty of making changes to your commit messages. You created two discussions, when what we normally make use of are issues. I have converted your discussions to issues, and I have updated the commit messages to point to the new issues.

Let me know if you have any questions.

Great thanks.
I'm on PTO this week so away from my Dev machine so thanks!

@BlythMeister
Copy link
Contributor Author

@microsoft-github-policy-service agree [company=15below]

@BlythMeister
Copy link
Contributor Author

@microsoft-github-policy-service agree

@BlythMeister
Copy link
Contributor Author

@microsoft-github-policy-service agree company="15below"

@BlythMeister
Copy link
Contributor Author

@gep13 I have no idea if those commands worked 🤣🤣
Hopefully they have

@gep13
Copy link
Member

gep13 commented Oct 25, 2022

@BlythMeister fingers crossed!

Just had a quick chat with @devlead and he was working on cutting over to a new version of CLA bot, and that work has just finished. Going forward, other folks shouldn't need to re-sign the CLA if they already have, but unfortunately, you were in the middle to the transition, which is why you had to do it.

Apologies about that!

@devlead
Copy link
Member

devlead commented Oct 25, 2022 •
edited
Loading

@gep13 I have no idea if those commands worked 🤣🤣 Hopefully they have

It worked🎉

image

@BlythMeister
Copy link
Contributor Author

@BlythMeister fingers crossed!

Just had a quick chat with @devlead and he was working on cutting over to a new version of CLA bot, and that work has just finished. Going forward, other folks shouldn't need to re-sign the CLA if they already have, but unfortunately, you were in the middle to the transition, which is why you had to do it.

Apologies about that!

No need to apologise.
It's all good!

devlead
devlead approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit dfeb573 into cake-build:develop Oct 25, 2022
@devlead
Copy link
Member

devlead commented Oct 25, 2022

@BlythMeister your changes have been merged, thanks for your contribution 👍

@gep13 gep13 changed the title TeamCity Messages Enhancements GH4018 GH4019:TeamCity Messages Enhancements Oct 25, 2022
@gep13 gep13 changed the title GH4018 GH4019:TeamCity Messages Enhancements GH4018 GH4019: TeamCity Messages Enhancements Oct 25, 2022
@BlythMeister BlythMeister deleted the teamcity branch March 8, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustoproiete augustoproiete augustoproiete approved these changes

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for TeamCity build status message Add Support For TeamCity Statistics
4 participants
@BlythMeister @gep13 @devlead @augustoproiete