Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cake.Buns.ReportPortal.yml #1924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Cake.Buns.ReportPortal.yml #1924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/Cake.Buns.ReportPortal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ Name: Cake.Buns.ReportPortal
NuGet: Cake.Buns.ReportPortal
Assemblies:
- /**/Cake.Buns.ReportPortal.dll
Repository: https://github.com/OlegYanushkevich/Cake.Buns.ReportPortal.git
ProjectUrl: https://github.com/OlegYanushkevich/Cake.Buns.ReportPortal/
Repository: https://github.com/OlegYanushkevich/Cake.Buns.ReportPortal/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repository / GitHub user seems to be removed.

@Jericho Isn't there a check in addin discoverer to avoid adding links leading to a 404 (or was the user removed just after addin discoverer was run)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do validate the ProjectUrl and replace it with a link to the nuget package when we detect HTTP 404. That's why the ProjectUrl in this YAML was changed:

  • from https://github.com/OlegYanushkevich/Cake.Buns.ReportPortal/
  • to https://www.nuget.org/packages/Cake.Buns.ReportPortal/.

However, the same logic is not applied to the repository URL. That's why the AddinDiscoverer did not update the RepositoryUrl (other than .git which the author seems to have removed in their nuspec).

ProjectUrl: https://www.nuget.org/packages/Cake.Buns.ReportPortal/
Author: OlegYanushkevich
Description: Cake extension for cleaning and merging ReportPortal launches.
Categories:
Expand Down