Support Cake 0.38.0 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdukes are you in a position to rebase this onto the current develop? |
nils-a
requested changes
Feb 3, 2021
TFBuild was renamed to AzurePipelines
|
@bdukes your changes have been merged, thanks for your contribution 👍 |
|
@nils-a Thanks! Any chance this change could be published sometime soon? |
|
👍 thanks for the update |
|
@bdukes I released version 1.0.0 which supports Cake 0.38.0 (i.e. this PR) - will update to Cake 1.0.0 (and release a new version of Cake.Buildsystems.Module) soon. |
|
Thanks @nils-a! I saw the release and am already running a build with it. It appears to be working on our project using Cake 1.0.0, are there features you would expect not to work? |
|
@bdukes No. I gave it a shakedown using the rc0003 when I tested your PR (nothing complex) and everything was fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TFBuildwas renamed toAzurePipelinesin Cake 0.38. This PR updates the usages and also updates the naming within theCake.TFBuild.ModuletoCake.AzurePipelines.Module.I think this is the only thing that would prevent this from working on 1.0.0 also.
Let me know if there are any adjustments I can make for you.
Thanks!