cw_decred: add libdcrwallet dependency and link library for android, ios and macos #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itswisdomagain
force-pushed
the
dcrlibwallet
branch
from
849750a to
661b2df
Compare
itswisdomagain
force-pushed
the
dcrlibwallet
branch
from
661b2df to
61f398c
Compare
OmarHatem28
approved these changes
Feb 27, 2024
cw_decred/lib/wallet_service.dart
Outdated
| final currentWallet = await DecredWalletBase.open( | ||
| password: password, name: currentName, walletInfo: currentWalletInfo); | ||
|
|
||
| final currentWallet = await openWallet(currentName, password); |
There was a problem hiding this comment.
calling openWallet function would load it and initialize it, which is not what we want when renaming the wallet, we just need to get it's instance and rename it along with its files (if it will be the same as Monero)
OmarHatem28
reviewed
Mar 6, 2024
There was a problem hiding this comment.
when dealing with file system we do expect some weird behaviors from different devices, so it's better to gracefully handle this here, and try other alternatives as well, you can check the renameWalletFiles function in monero_wallet and you can see what I mean.
non blocker so I will merge anyway, but something to consider adding in future PRs.
JoeGruffins
added a commit
to JoeGruffins/cake_wallet
that referenced
this pull request
Mar 7, 2024
…ios and macos (cake-tech#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <joegruffins@gmail.com>
JoeGruffins
added a commit
to JoeGruffins/cake_wallet
that referenced
this pull request
Apr 3, 2024
…ios and macos (cake-tech#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <joegruffins@gmail.com>
JoeGruffins
added a commit
to JoeGruffins/cake_wallet
that referenced
this pull request
Jul 12, 2024
…ios and macos (cake-tech#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <joegruffins@gmail.com>
JoeGruffins
added a commit
to JoeGruffins/cake_wallet
that referenced
this pull request
Jul 12, 2024
…ios and macos (cake-tech#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <joegruffins@gmail.com>
JoeGruffins
added a commit
to JoeGruffins/cake_wallet
that referenced
this pull request
Jul 12, 2024
…ios and macos (cake-tech#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <joegruffins@gmail.com>
JoeGruffins
added a commit
to JoeGruffins/cake_wallet
that referenced
this pull request
Jul 12, 2024
…ios and macos (cake-tech#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <joegruffins@gmail.com>
JoeGruffins
added a commit
to JoeGruffins/cake_wallet
that referenced
this pull request
Oct 17, 2024
…ios and macos (cake-tech#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <joegruffins@gmail.com>
JoeGruffins
added a commit
to JoeGruffins/cake_wallet
that referenced
this pull request
Oct 18, 2024
…ios and macos (cake-tech#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <joegruffins@gmail.com>
JoeGruffins
added a commit
to JoeGruffins/cake_wallet
that referenced
this pull request
Dec 12, 2024
…ios and macos (cake-tech#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <joegruffins@gmail.com>
JoeGruffins
added a commit
to JoeGruffins/cake_wallet
that referenced
this pull request
Dec 26, 2024
…ios and macos (cake-tech#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <joegruffins@gmail.com>
OmarHatem28
pushed a commit
that referenced
this pull request
Jan 5, 2025
* multi: Add initial decred screens. (#1165) Use a mock libwallet for now. * cw_decred: add libdcrwallet dependency and link library for android, ios and macos (#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <joegruffins@gmail.com> * decred: Add sync. * decred: Add send transaction. * decred: Fix fee estimation. * decred: List transactions. * decred: Add rescan. * decred: Sign message. * decred: Add new addr and addrs. * decred: Add change wallet pass. * decred: Add restore from seed. * decred: Add watching only wallets. * decred: Enable mainnet. * decred: Allow using blank node address. This allows a persistent peer to be unset, falling back to decred seeders. * decred: Rescan from wallet birthday. * add and update macos build scripts, update build readme, gitignore macos project.pbxproj Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com> * multi: hide decred rescan page if it's not ready - move hasRescan method to WalletBase and implement for decred Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com> * cw_decred: fix bug where decred wallets are not loaded after app restart Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com> * add buy and sell for decred via onramp Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com> * bug-fix: account for other send outputs that are part of the same tx Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com> * decred: Return address with no peers. * decred: Update pubspec. * decred: Add verify message. * upgrade hive_generator dep in cw_decred * decred: Clean up code. --------- Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com> Co-authored-by: Wisdom Arerosuoghene <wisdom.arerosuoghene@gmail.com> Co-authored-by: Philemon Ukane <ukanephilemon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
Builds on #1165.
Adds build scripts for building the decred wallet library for android, ios and macos.
Pull Request - Checklist