Cw 872 nano enhancements #1909
Merged
Cw 872 nano enhancements #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarHatem28
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Looks good,
only 2 things:
- shouldn't
N2_REPS_ENDPOINTbe changed depending on the user selected representative? - please review the PR yourself, as I see there are some headers that you will get from the
pownode and some from the normal node, so just double check that all of the functions are using the appropriate node
|
The N2_REPS_ENDPOINT is a custom endpoint by estaban that gives info about all nodes to help users decide on a representative, it's what we use to display the list of reps to choose from |
OmarHatem28
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist