Skip to content

Commit

Permalink
Merge pull request #49 from javierjulio/patch-1
Browse files Browse the repository at this point in the history
Bump node16 to node20 to fix deprecation
  • Loading branch information
cakeinpanic authored Mar 1, 2024
2 parents 5464a11 + 1536f06 commit c414eaf
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 60 deletions.
18 changes: 3 additions & 15 deletions .github/workflows/pr-branch-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,11 @@ jobs:
build-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
name: setup node
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'

- name: Cache node modules
uses: actions/cache@v2
env:
cache-name: cache-node-modules
with:
path: node_modules
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-
${{ runner.os }}-build-
${{ runner.os }}-
cache: npm

- name: "install"
run: npm ci --production
Expand Down
18 changes: 3 additions & 15 deletions .github/workflows/pr-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,11 @@ jobs:
build-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
name: setup node
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'

- name: Cache node modules
uses: actions/cache@v2
env:
cache-name: cache-node-modules
with:
path: node_modules
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-
${{ runner.os }}-build-
${{ runner.os }}-
cache: npm

- name: "install"
run: npm ci --production
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ outputs:
jira-issue-source:
description: 'Indication how the jira issue was found, by - branch | pr-title | null'
runs:
using: 'node16'
using: 'node20'
main: 'lib/index.js'
branding:
icon: 'terminal'
Expand Down
35 changes: 11 additions & 24 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"url": "git+https://github.com/cakeinpanic/jira-description-action"
},
"engines": {
"node": ">= 16",
"npm": ">= 8"
"node": ">= 20",
"npm": ">= 10"
},
"keywords": [
"actions",
Expand Down Expand Up @@ -45,10 +45,9 @@
"@actions/core": "^1.10.1",
"@actions/github": "^5.1.1",
"@octokit/rest": "^20.0.1",
"@octokit/webhooks-definitions": "^3.67.3",
"@types/jest": "^25.2.3",
"@types/node": "^13.13.30",
"@zeit/ncc": "^0.22.3",
"@vercel/ncc": "^0.38.1",
"axios": "^0.19.2",
"engines-ok": "^1.2.0",
"jest": "^25.5.4",
Expand Down

0 comments on commit c414eaf

Please sign in to comment.