Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cake 5: Sort param and return type hints #335

Merged
merged 1 commit into from
Jul 11, 2021
Merged

cake 5: Sort param and return type hints #335

merged 1 commit into from
Jul 11, 2021

Conversation

othercorey
Copy link
Member

@othercorey othercorey added this to the 5.0 milestone Jul 9, 2021
@othercorey othercorey force-pushed the type-order branch 2 times, most recently from 720911c to df81a41 Compare July 9, 2021 06:43
@othercorey othercorey force-pushed the type-order branch 2 times, most recently from dede496 to 3c8408f Compare July 9, 2021 23:27
@othercorey
Copy link
Member Author

othercorey commented Jul 9, 2021 •
edited
Loading

I moved this into a separate sniff file and extended it to support var tags. Also extended to support psalm- and phpstan- pefixes.

Added names that are used with generics to the sort list so they aren't pushed all the way to the back. class-string<\Type>

@othercorey othercorey force-pushed the type-order branch 6 times, most recently from fab27e9 to d0a1bd9 Compare July 10, 2021 23:16
@othercorey
Copy link
Member Author

othercorey commented Jul 10, 2021 •
edited
Loading

Updated to include type[] to array<type> type hint conversion.

@othercorey othercorey merged commit 3b1245a into 5.0 Jul 11, 2021
@othercorey othercorey deleted the type-order branch July 11, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADmad ADmad ADmad left review comments

@dereuromark dereuromark dereuromark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.
3 participants
@othercorey @dereuromark @ADmad