Updated SQLite3 to allow UUID PK's #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified dbo_sqlite3.php to allow for UUID PK
sqlite_sequence table shows up when listing sources and breaks function describe()
Fixed default table type so primary key is integer type with autoincrement
|
These changes look fine but the absence of a test (which is the fault of the repo, not the person opening a PR) makes me nervous to merge it. Can someone using sqlite3 test/vouch for this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues with table creation so default PK has type integer autoincrement
Original pull request was closed due to this issue, #21