Add docs for HtmlHelper::importmap() #7985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Jan 21, 2025
en/views/helpers/html.rst
Outdated
| } | ||
| }, | ||
| "integrity": { | ||
| "/js/jquery.js": "sha256-hash" |
There was a problem hiding this comment.
I wonder if we should make this example more complete, or skip it? Having a broken example in the docs doesn't feel good, as the copy-paster is going to have an error. For this to work correctly, we need the base64_encode(sha256) of the file contents.
There was a problem hiding this comment.
I have updated the integrity example.
ADmad
force-pushed
the
5.2-importmap
branch
3 times, most recently
from
d3c4364 to
cd61a85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.