-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abandon macos universal2 builds for arch-specific builds #134
Conversation
Still didn't do it.
|
https://github.com/caketop/python-starlark-go/actions/runs/3971303726/jobs/6808045882#step:5:200 in which I attempted to set GOARCH explicitly based on the CIBW_ARCH gives me a go build error I've not seen. |
I got this working locally:
After that I was able to run Let's see if it works in CI. My Mac is an M1 Pro but I know GitHub's runners are still Intel boxes, so the cross-compiling will be happening the other way in CI. |
@colindean This seems ready-to-go; if you could grab the wheel out of https://github.com/caketop/python-starlark-go/actions/runs/3981639195 (download the "Artifacts" zip and they'll all be in there) and give me the "Works On My Machine" certification, then I'll merge this. |
This should work! |
🎉 |
I put i686 builds back and went ahead and tagged 1.0.0 since this seems settled enough that I'm not going to want to upend the API any time soon. I'll write a blog post about it tomorrow. |
1.0.0 blog post here: https://jordemort.dev/blog/python-starlark-go-1.0.0/ |
Thanks for the mention in the write-up! |
After messing with #131 for too long, @jordemort suggested a simpler route: ditch universal builds and stick to separate arches. This became easier after realizing that we'd need to use some tooling to combine the arm64 and x86_64 artifacts into one universal2 binary using
lipo
, and that would necessitate more changes to the build than it's worth.Closes #131