Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch segment_calcs np.percentile #1185

Merged
merged 3 commits into from
Jul 23, 2024
Merged

patch segment_calcs np.percentile #1185

merged 3 commits into from
Jul 23, 2024

Conversation

edasmalchi
Copy link
Member

see #1184 for context

tested in: https://github.com/cal-itp/data-analyses/blob/eric-bbb-exploratory/rt_segment_speeds/38_bbb_speeds_legacy_compare.ipynb

with this change, speeds and aggregations substantially align for BBB via both legacy speedmaps and segment speeds

Screenshot 2024-07-23 130438 Screenshot 2024-07-23 130454 Screenshot 2024-07-23 130505

Copy link

nbviewer URLs for impacted notebooks:

Copy link
Member

@tiffanychu90 tiffanychu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoohoo! Lol, never noticed that line at all, great catch!

@edasmalchi edasmalchi merged commit 6bcf96e into main Jul 23, 2024
3 checks passed
@edasmalchi edasmalchi deleted the eric-bbb-exploratory branch July 23, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants