-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor monthly ntd ridership portfolio site #1190
Conversation
@csuyat-dot: for the merge conflicts above...is it caused by not running this line?
|
…to see what needs to change to accomdate this new table in the existing scripts
…how the df changes
…ode, and tos. then subtract the upt of the previous year/month but same ntd id, mode, and tos
…e df by agency/mode/tos/month/year
…d_monthly... function
…td_monthly...v2. EVERYTHING WORKS!
…g to temp GCS folder. about to move v2 functions to TEST scripts and reports
…ction. need to test charts next
…om new functions to minimize function name changes in the rest of the portfolio. also was able to filter incoming data to charts to match current portfolio
…m_by_group to get % change col and then testing charts with % change data instead of change in upt.
…2024-05 data. still start to move refactored fucntions over to prod scripts
… transferred the refactored changes to TEST script and NB. ran TEST NB and script with no issues. ready to go into final NB and script
… publishing online!
ef9c194
to
da647e0
Compare
Initially, this PR had merge conflicts with the checked in parameterized notebooks. Conflicts possibly stem from: parameterizing notebooks multiple times, blindly checking in files not normally checked in with the Steps taken to resolve merge conflicts include:
Note, an alternate PR #1191 was created in case this PR was not able to be resolved. Alternate PR was able to check in specific files and deploy notebooks with no conflicts. This confirms that the scripts and notebooks work, but that something between git, local, and main may be the problem. |
With the
dim_monthly_ntd_ridership_with_adjustment
table in the warehouse, there is no longer a need to ping the NTD website and extract the wide data from their excel document. Functions were refactored to accept the new, long version of the data in the warehouse.With the data now in a long format, a lot of initial functions are no longer needed and thus removed. Refactored functions produce identical charts with identical values.
One major difference in
change in UPT from prior year by...
charts. We now have change in UPT data going back to 2018, when previously we were only able to calculate/display change in UPT data from 2024 due to the wide format of the data.before:
after:
It is possible to add a "2024" filter to mimic the initial charts.
Other changes, per #990:
.xlsx
files.READ ME
tab that defines the column names, Modes and TOS types.Successfully ran all these changes locally via
make ntd_monthly_export
, saw notebooks parameterized, see data outputs in both public/private GCS, and see updated charts published online.