-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Initial GTFS "Catalog" #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general.
Two thoughts:
- Create an entry for all transit providers even if they don't currently have a feed (empty list).
- Add documentation [ somewhere ] including any implied meaning from ordering of feeds in the list.
|
Which "master list"? The Google Sheets one? AFIK that would require access to our google drive. We should probably have some sort of public version. [ we can discuss on Weds :-) ] |
Hey--I'm noticing the gtfs_schedule_url in the yaml config is a list, but a single column in the sheet. Is the use of a list in the yaml by design? What should happen when there are two schedule url entries? (guessing there is a good reason for it, so this question is more for my understanding :) |
Yep! You might want to take a look at #21, which a very long thread about the nature of feeds. at least one agency in CA, LA metro produces two feeds (one rail / one bus), so rather than store that with a , separating (as in th sheet) I split into a list. additionally, every agency in the MTC region (bay area) often produces their own feed plus participates in the Bay Area Regional GTFS that should be the same, but we should list both in the catalog |
Ah, thanks--I've been crawling down #21, and think it is slowly coming together. Guessing that this means the "primary key" for each url entry is Should work okay in most circumstances, but I wonder if weird things could happen if there were initially two url entries, and the first ended up being removed. |
Yep, since for storage each run is the {run_time}/{itp_id}/{url}/(zip
contents), if we remove one from the list, it should just not be there for
future runs./
…On Tue, Mar 16, 2021 at 1:32 PM Michael Chow ***@***.***> wrote:
Ah, thanks--I've been crawling down #21
<#21>, and think it is slowly
coming together. Guessing that this means the "primary key" for each url
entry is <agency id> x <url entry index>?
Should work okay in most circumstances, but I wonder if weird things could
happen if there were two url entries, and the first ended up being removed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANHXYRN2NYGBOQILFHVRY3TD6555ANCNFSM4ZBCD4DQ>
.
|
gonna merge this knowing that it gets moved and updated in #25 |
This PR converts the existing GTFS spreadsheet from the drive and creates rows for every agency with a GTFS URL that starts with http(s). Missing agencies that have "in google" or "not in google" filled out and I haven't loaded RT feeds yet.
I think, to load RT feeds, the best option is to join on transitland atlas via NTP ID, but curious if we've been tracking those URL(s) elsewhere.