Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Initial GTFS "Catalog" #23

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Create Initial GTFS "Catalog" #23

merged 1 commit into from
Mar 18, 2021

Conversation

hunterowens
Copy link
Member

This PR converts the existing GTFS spreadsheet from the drive and creates rows for every agency with a GTFS URL that starts with http(s). Missing agencies that have "in google" or "not in google" filled out and I haven't loaded RT feeds yet.

I think, to load RT feeds, the best option is to join on transitland atlas via NTP ID, but curious if we've been tracking those URL(s) elsewhere.

Copy link
Contributor

@e-lo e-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.
Two thoughts:

  1. Create an entry for all transit providers even if they don't currently have a feed (empty list).
  2. Add documentation [ somewhere ] including any implied meaning from ordering of feeds in the list.

@hunterowens
Copy link
Member Author

  1. I thought about this but decided against it since the master "list" remains the spreadsheet, and therefore, to determine something like % listing GTFS feeds, you should do a left join. Additionally, there's the open question that invites on should we have "empty list but only for agencies that should have GTFS (ie, operate fixed route, etc)
  2. Once the list has implied meaning, I'll add docs for it. For now, we haven't incorporate the MTC subfeeds etc

@e-lo
Copy link
Contributor

e-lo commented Mar 15, 2021

  1. I thought about this but decided against it since the master "list" remains the spreadsheet, and therefore, to determine something like % listing GTFS feeds, you should do a left join. Additionally, there's the open question that invites on should we have "empty list but only for agencies that should have GTFS (ie, operate fixed route, etc)

Which "master list"? The Google Sheets one? AFIK that would require access to our google drive. We should probably have some sort of public version. [ we can discuss on Weds :-) ]

@machow
Copy link
Contributor

machow commented Mar 16, 2021

Hey--I'm noticing the gtfs_schedule_url in the yaml config is a list, but a single column in the sheet. Is the use of a list in the yaml by design? What should happen when there are two schedule url entries?

(guessing there is a good reason for it, so this question is more for my understanding :)

@hunterowens
Copy link
Member Author

Yep! You might want to take a look at #21, which a very long thread about the nature of feeds.

at least one agency in CA, LA metro produces two feeds (one rail / one bus), so rather than store that with a , separating (as in th sheet) I split into a list.

additionally, every agency in the MTC region (bay area) often produces their own feed plus participates in the Bay Area Regional GTFS that should be the same, but we should list both in the catalog

@machow
Copy link
Contributor

machow commented Mar 16, 2021

Ah, thanks--I've been crawling down #21, and think it is slowly coming together. Guessing that this means the "primary key" for each url entry is <agency id> x <url entry index>?

Should work okay in most circumstances, but I wonder if weird things could happen if there were initially two url entries, and the first ended up being removed.

@hunterowens
Copy link
Member Author

hunterowens commented Mar 16, 2021 via email

@hunterowens
Copy link
Member Author

gonna merge this knowing that it gets moved and updated in #25

@hunterowens hunterowens merged commit 6da6f68 into main Mar 18, 2021
@machow machow mentioned this pull request May 7, 2021
@machow machow deleted the gtfs-list branch October 4, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants