Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: cleanup devcontainer and project #69

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Chore: cleanup devcontainer and project #69

merged 3 commits into from
Sep 15, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Sep 14, 2023 •
edited
Loading

  • Upgrade devcontainer to Python 3.11
  • Fix devcontainer syntax, extensions, build process
  • Simplify on pyproject.toml exclusively
  • Better coverage reporting
  • Bump library version for coming release

Closes #10

@thekaveman thekaveman requested a review from a team as a code owner September 14, 2023 17:47
@thekaveman thekaveman self-assigned this Sep 14, 2023
@github-actions
Copy link

Coverage report

Note

Coverage data for the default branch was not found.
This usually happens when the action has not run on the default
branch yet, for example right after deploying it into the workflows.

The coverage rate is 47.39%.
The branch rate is 62%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@thekaveman thekaveman added the chore Chores and tasks for code cleanup, dev experience, etc. label Sep 14, 2023
angela-tran
angela-tran approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to rebuild and open the devcontainer with this setup

@thekaveman thekaveman merged commit 00044ae into main Sep 15, 2023
2 checks passed
@thekaveman thekaveman deleted the chore/cleanup branch September 15, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
chore Chores and tasks for code cleanup, dev experience, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create requirements.txt for devcontainer
2 participants
@thekaveman @angela-tran