Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: pipdeptree #336

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Feat: pipdeptree #336

merged 2 commits into from
Sep 29, 2023

Conversation

angela-tran
Copy link
Member

Closes #334

Similar to cal-itp/benefits#1733

@angela-tran angela-tran self-assigned this Sep 28, 2023
@angela-tran angela-tran marked this pull request as ready for review September 28, 2023 18:24
@angela-tran angela-tran requested a review from a team as a code owner September 28, 2023 18:24
thekaveman
thekaveman previously approved these changes Sep 28, 2023
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela-tran
Copy link
Member Author

@thekaveman Hmm, maybe it'll create the file if it doesn't exist but not necessarily any parent directories. I'll test out this workflow more - gonna try running it locally with act!

@angela-tran
Copy link
Member Author

I was able to reproduce the issue with act 😍

image

I think this means we need to add a step to create the static directory so that it can have both sha.txt and requirements.txt in it.

For benefits we don't need this step since we already have a static directory with other stuff in it

@angela-tran
Copy link
Member Author

With the step added in c3c010c, I got act to successfully write to eligibility_server/static/sha.txt and eligibility_server/static/requirements.txt, so hopefully it works in GitHub too!

image

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🙏 act

@angela-tran angela-tran merged commit 02063e8 into dev Sep 29, 2023
5 checks passed
@angela-tran angela-tran deleted the feat/pipdeptree branch September 29, 2023 17:04
@angela-tran angela-tran mentioned this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make git SHA and pipdeptree available as static files
2 participants