Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: build Docker image with unshallow copy #392

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

angela-tran
Copy link
Member

Closes #391

@angela-tran angela-tran self-assigned this Dec 19, 2023
@angela-tran angela-tran requested a review from a team as a code owner December 19, 2023 22:53
Copy link

Coverage report

Note

Coverage data for the default branch was not found.
This usually happens when the action has not run on the default
branch yet, for example right after deploying it into the workflows.

The coverage rate is 84.98%.
The branch rate is 85%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@angela-tran angela-tran merged commit 6a6ab04 into dev Dec 20, 2023
7 checks passed
@angela-tran angela-tran deleted the fix/docker-publish-unshallow branch December 20, 2023 20:46
@angela-tran
Copy link
Member Author

This worked!

From Azure for dev instance:

023-12-20T22:22:27.401681466Z + bin/init.sh
2023-12-20T22:22:27.462608121Z + flask init-db
2023-12-20T22:22:35.993407299Z SENTRY_DSN not set, so won't send events
2023-12-20T22:22:35.993438699Z [2023-12-20 22:22:35,993] INFO eligibility_server.app:31 Starting Eligibility Server 2023.11.1rc2.dev37+g0f1456f

@thekaveman
Copy link
Member

@angela-tran this was a great find and fix!

I think it can be done a bit simpler directly from the actions/checkout@v4 step:

- uses: actions/checkout@v4
  with:
    # Number of commits to fetch. 0 indicates all history for all branches and tags.
    # Default: 1
    fetch-depth: 0 
    
    # Whether to fetch tags, even if fetch-depth > 0.
    # Default: false
    fetch-tags: true

Maybe the fetch-depth doesn't matter as much when we force fetch-tags, which would be even simpler!

@thekaveman thekaveman mentioned this pull request Jan 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the Docker image built by GitHub Actions behaves similar to one built locally
3 participants