Making it work on OSX 10.7.4, where tar fails silently to extract the iso #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let tar extract the iso file
| @@ -59,6 +59,25 @@ if [ ! -e "${FOLDER_ISO}/custom.iso" ]; then | |||
| echo "Untarring downloaded ISO ..." | |||
| tar -C "${FOLDER_ISO_CUSTOM}" -xf "${ISO_FILENAME}" | |||
|
|
|||
| # in osx lion 10.7.4, tar won't extract anything and will fail silently. If that happens, look for a newer version of bsd tar | |||
| if [ ! `ls $FOLDER_ISO_CUSTOM` ]; then | |||
There was a problem hiding this comment.
not sure if there's a better way to check if a folder is empty, but this works
|
+1 -- Installing a more recent libarchive with Homebrew and this patch made it work for me. It should be merged. |
|
+1 |
|
oof this is good to know. I hit this as well...used p7zip from brew but if bsdtar is in osx already... |
|
+! - Tested and works great. |
|
This fixed my problem as well. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, great script - it's annoying that the default vagrant box is an old version.
I tried to run it this morning, and ran into a couple of issues - first with brew installing cdrtools (using a slightly outdated version of XCode). I updated XCode and got that working, but then tar was failing silently on extracting from the ISO file.
I solved the problem by updating to a more recent "homebrew-dupes" version of libarchive as recommended in this thread: http://forums.macrumors.com/showthread.php?t=1377464
This pull request updated the README to outline those two potential issues and their fixes, and I updated
build.shto try using the homebrew installed bsdtar if the tar output is empty.Googling for the first cdrtools problem, I saw it was a common problem with smake and OSX Lion. And there is an open Github issue on the project for the empty tar output problem, so it seems like other people are having the same problem with tar 2.8.3.