This repository has been archived by the owner on May 16, 2023. It is now read-only.
Make the http method in the Websocket request struct optional. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is optional, but the Go bindings don't mark it as such. Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
Signed-off-by: David Calavera <david.calavera@gmail.com>
|
@LegNeato can you take a look at this change? it's using the latest master branch of aws-lambda-go with the http method field omited. |
LegNeato
approved these changes
Mar 5, 2021
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LegNeato I made some adjustments to properly serialize and deserialize the optional method. The code should still work correctly after the Go bindings are fixed, but we can also retouch this patch then.
Fixes #33
Signed-off-by: David Calavera david.calavera@gmail.com