Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getRootNodeName return #914

Merged
merged 1 commit into from
May 5, 2024
Merged

fix getRootNodeName return #914

merged 1 commit into from
May 5, 2024

Conversation

rushork
Copy link
Contributor

@rushork rushork commented May 3, 2024

A fix for the problem first raised in #871.

This return from the getRootNodeName function was incorrectly deleted in #801, making it unable to save TrackingOptions correctly e.g. the following way:

  $option = new TrackingOption();
  $option->setName($name);
  $tracking->addOption($option);
  $tracking->save();

The suggested change is to reinstate what it was previously and allow TrackingOptions to be saved properly. Interestingly, it seems to allow one TrackingOption to be generated but I try to add another to the same Tracking Category it does not save.

@calcinai calcinai merged commit b253f97 into calcinai:master May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants