fix: SAML: invalid_code issue, missing user error signing up #15522
+4
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (06/21/24)1 reviewer was added to this PR based on Keith Williams's automation. |
dosubot
bot
added
the
authentication
emrysal
changed the title
emrysal
changed the title
keithwillcode
approved these changes
Jun 24, 2024
emrysal
added a commit
that referenced
this pull request
Jun 25, 2024
* fix: Error thrown due to missing user * chore: Remove unnecessary logs * fix: Remove PageWrapper in order to prevent double signIn * Change profile typing to optional * further type fix * further type fix..
p6l-richard
pushed a commit
to p6l-richard/cal.com-fork
that referenced
this pull request
Jul 22, 2024
…15522) * fix: Error thrown due to missing user * chore: Remove unnecessary logs * fix: Remove PageWrapper in order to prevent double signIn * Change profile typing to optional * further type fix * further type fix..
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PageWrapper HOC re-renders, causing a re-fire of signIn which results in "invalid code" - this PR removes that wrapper (seems to have 0 side effects) and also makes an update to the profile as on initial registration we have no existing user - as per my testing.