chore: streamline ready-for-e2e label check for PRs #15545
Merged
+38
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (06/23/24)1 reviewer was added to this PR based on Keith Williams's automation. |
keithwillcode
changed the title
keithwillcode
commented
Jun 23, 2024
| @@ -41,71 +41,75 @@ jobs: | |||
| name: Check for E2E label | |||
| outputs: | |||
| run-e2e: ${{ steps.check-if-pr-has-label.outputs.run-e2e == 'true' && (github.event.action != 'labeled' || (github.event.action == 'labeled' && github.event.label.name == 'ready-for-e2e')) }} | |||
| run-jobs: ${{ github.event.action != 'labeled' }} | |||
There was a problem hiding this comment.
This boolean condition was not accurate and causing issues running the other jobs
PeerRich
approved these changes
Jun 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
p6l-richard
pushed a commit
to p6l-richard/cal.com-fork
that referenced
this pull request
Jul 22, 2024
* Added a log for pull_request * Added labels logging * Using labels straight from event PR object * Converting to JSON * Switching to use payload * Fixed issue with undefined pr * Fixed non-mapping issue * Removed the types * Removed issue with run-jobs * Put back the types
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
pull_requestobject to get the labels when available instead of always calling the GitHub API.