Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: settings/organizations - remove pages router and use app router #16774

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: settings/organizations - remove pages router and use app router #16774

wants to merge 8 commits into from

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Sep 23, 2024

What does this PR do?

  • Fixes CAL-4391
  • remove pages router and use app router for all pages in settings/organizations
  • remove env vars not needed anymore as a result

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • all settings/organizations/**/* pages must work as expected

@linear Linear
Copy link

linear bot commented Sep 23, 2024

CAL-4391 `settings/organizations` - Use app router and remove pages router

@hbjORbj hbjORbj added the high-risk Requires approval by Foundation team label Sep 23, 2024
@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Sep 23, 2024
@graphite-app graphite-app bot requested review from a team September 23, 2024 17:37
@keithwillcode keithwillcode added consumer core area: core, team members only labels Sep 23, 2024
@hbjORbj hbjORbj marked this pull request as draft September 23, 2024 17:37
@dosubot dosubot bot added organizations area: organizations, orgs 💻 refactor labels Sep 23, 2024
@hbjORbj
Copy link
Contributor Author

hbjORbj commented Sep 23, 2024

TODO: Add CTA Button to settings/organizations/teams/other/[id]/members

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 23, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/23/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (09/23/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj removed request for a team September 23, 2024 17:55
@vercel Vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 6:44pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 6:44pm

@hbjORbj hbjORbj marked this pull request as ready for review September 24, 2024 15:48
@dosubot dosubot bot added the routing-forms area: routing forms, routing, forms label Sep 24, 2024
@hbjORbj hbjORbj marked this pull request as draft September 25, 2024 14:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2024 •
edited
Loading

E2E results are ready!

@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Oct 21, 2024
@github-actions github-actions bot removed the Stale label Oct 22, 2024
@hbjORbj hbjORbj marked this pull request as ready for review November 5, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables high-risk Requires approval by Foundation team organizations area: organizations, orgs ready-for-e2e 💻 refactor routing-forms area: routing forms, routing, forms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbjORbj @keithwillcode